feat: add win32-x64 platform support - #91
Draft
shatakshiiii wants to merge 2 commits into
Draft
Conversation
Lockfile had mismatched rolldown JS (1.0.3) vs native bindings (1.1.5), which broke vitest startup. Pin vite so bindings align, and remove no-explicit-any warnings so lint stays at zero. Co-authored-by: Cursor <cursoragent@cursor.com>
Ship a fourth platform so Windows users and vscode-ansible CI can install redhat.abbenay-provider. Use 127.0.0.1 + daemon.addr for local IPC (named-pipe gRPC remains out of scope), extend bootstrap/CI/release, and record DR-043. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
win32-x64as a fourth supported platform (CI, release, VSIX packaging) so Windows users and vscode-ansible can installredhat.abbenay-provider(#64, AAP-82970).127.0.0.1+ ephemeral port) withdaemon.addrfor Windows local IPC instead of named-pipe gRPC; Linux/macOS Unix sockets unchanged (DR-043).bootstrap.shfor Windows Node zip layout, add Windows build/smoke in CI/release, and fix packaging to shipabbenay-daemon-win32-x64.exe+keytar.node.Commits
chore(deps): pin vite 8.1.5 and clear select-model lint warnings— align rolldown JS/native bindings so vitest starts; keep lint at zero warningsfeat: add win32-x64 platform support with loopback TCP IPC— transport, packaging, bootstrap, CI/release, docs/DR-043, tests and Windows smoke scriptTest plan
npm run lintpasses locally (0 errors, 0 warnings)npm testpasses locally (daemon + VS Code)npm run ci:buildpasses locallydaemon.addrhelpers, SEA.exenamingwindows-latestmatrix builds VSIX + runsnpm run ci:smoke-win32-ipcCloses #64
Made with Cursor