feat(intelligent-assistant): screen context chip, kebab opt-in, and gated attachments ( - #4862
its-mitesh-kumar wants to merge 8 commits into
Conversation
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
/fs-review |
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
🤖 Finished Review · ✅ Success · Started 7:45 PM UTC · Completed 8:10 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $9.61 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4862 +/- ##
==========================================
+ Coverage 60.14% 60.29% +0.14%
==========================================
Files 2673 2679 +6
Lines 106162 106660 +498
Branches 29807 29943 +136
==========================================
+ Hits 63856 64310 +454
- Misses 41789 41832 +43
- Partials 517 518 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Risk Assessment: moderate (2/5) DetailsLarge-footprint feature addition (2500 lines, 31 files) from a regular contributor with good test coverage and no protected-path, security, CI, or dependency concerns; elevated regression history on LightSpeedChat.tsx offset by majority new files. |
ReviewFindingsHigh
Medium
Low
Next steps:
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
…IDP-14319 Fill gating-matrix and kebab RTL gaps, and add mocked Playwright journeys for kebab/chip/pause/fullscreen so QE layers under RHIDP-14768 can gate the Deep Context UX. Co-authored-by: Cursor <cursoragent@cursor.com>
Complete CaptureResult mocks for tsc, and assert paused-send attachments via the same query route pattern used by MCP specs (no try/catch). Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid Escape between kebab verify/enable (it closes the chatbot), re-enable sharing after fullscreen remount for guest e2e, and wait on the Options control in the chat header. Assisted-by: Composer Co-authored-by: Cursor <cursoragent@cursor.com>
… strict mode getByText on the paused label matched both the Label button and inner span; use the same state CSS class pattern as recording/unavailable. Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
New changes are detected. LGTM label has been removed. |
|
@debsmita1 I have addressed your comment and verify it, its working fine. If no other comment then we can get this PR in. |
…ext-coverage test(intelligent-assistant): screen context L1/L3/L4a coverage (RHIDP-14319)
|
4 participants
Summary
Implements the screen context UX for the Intelligent Assistant message bar: users opt in via the header kebab, see a context chip that reflects recording/paused/unavailable states, and send messages with DOM and/or screenshot context only when admin config, user settings, model capabilities, and display mode allow it.
Changes
useScreenContextSettingspersistsscreenContextSharingEnabledandscreenContextPausedin thelightspeedStorageApi bucket (sharing defaults to off).ScreenContextChipwith dynamic labels/tooltips (search, software templates, settings breadcrumbs, catalog routes) and label refresh on SPA navigation via history/MutationObserver subscription.screen-context-utilscentralizesshouldAttachScreenContext/buildScreenContextAttachments(adminscreen-context.enabled, user sharing, pause, non-fullscreen; DOM viadom-extraction.enabled; screenshots viascreenshots.enabled+ modelsupportsVision).data-screen-capture-exclude.ref.tsand locale files; alpha API report updated.LightspeedChat/ RBAC gating tests registerstorageApiReffor the new hook.Config
UI after changes
S_.2026-09-18.at.12.32.07.AM.mov
S_.2026-09-18.at.12.36.01.AM.mov
S_.2026-09-18.at.8.37.11.AM.mov
S_.2026-09-18.at.8.mp4
Test plan
screen-context.enabledis true./create/templates, and template detail; confirm chip label and tooltip update.yarn testinworkspaces/intelligent-assistant/plugins/intelligent-assistantRelated