fix(x2a): trust extra CAs for converter Job git clone - #4865
Open
mareklibra wants to merge 3 commits into
Open
mareklibra wants to merge 3 commits into
mareklibra wants to merge 3 commits into
Conversation
Fixes: FLPATH-4871 GitLab clone failed on a private CA because git runs in the Job, not the Hub. Mount extra issuing CAs and keep skip-TLS as a last-resort hatch (FLPATH-4871). Signed-off-by: Marek Libra <marek.libra@gmail.com>
Follow-up to FLPATH-4871: mount the CNO-injected cluster CA bundle so operators need not paste PEM already in user-ca-bundle. Signed-off-by: Marek Libra <marek.libra@gmail.com>
mareklibra
requested review from
a team,
eloycoto and
yray-pixel
as code owners
September 18, 2026 12:42
Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4865 +/- ##
==========================================
+ Coverage 63.52% 63.58% +0.06%
==========================================
Files 2681 2684 +3
Lines 106848 107030 +182
Branches 29905 29918 +13
==========================================
+ Hits 67870 68058 +188
+ Misses 37207 37201 -6
Partials 1771 1771
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
shouldn't we add the CA into the secrets in the deployment directly? Having a way to add a custom CA, sems a bit insecure to me, and I do not think that scales well enough (What happens if multiple CA, etc..) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(x2a): trust extra CAs for converter Job git clone
Fixes: FLPATH-4871
GitLab clone failed on a private CA because git runs in the Job, not the Hub.
Mount extra issuing CAs and keep skip-TLS as a last-resort hatch.