Conversation
alizard0
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
September 20, 2026 13:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lightspeed/release-1.10 #4884 +/- ##
==========================================================
Coverage ? 60.96%
==========================================================
Files ? 2098
Lines ? 65167
Branches ? 16942
==========================================================
Hits ? 39726
Misses ? 25219
Partials ? 222
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps transitive dependencies to address CVEs for RHDH 1.10.5.
Fixed with
yarn upofexpressandbody-parserinworkspaces/lightspeedso the formerqs@~6.14.0pin from those parents resolves to6.16.0.Which issue(s) does this PR fix
qs:How to test changes / Special notes to the reviewer
qs(6.16.0),express(4.22.3), andbody-parser(1.20.8) are fully patched on every installed path.qsis fully patched on published plugin production trees (6.16.0).express@4.22.3andbody-parser@1.20.8now declareqs@~6.16.0. Deciding production paths:lightspeed-backenddependencies→express@4.22.3(^4.21.1) →qs;lightspeeddependencies→@backstage/core-components@0.18.8(^6.9.4) →qs;lightspeed-backenddependencies→@backstage/backend-defaults@0.16.0→express→qs. CLI/test paths (@backstage/cli,supertest,@backstage/backend-test-utils) also resolve to6.16.0.yarn why -R qsshows no leftover vulnerable versions.body-parser1.20.4→1.20.8also includes the1.20.6fix for CVE-2026-12590.path-to-regexpstayed at0.1.13(descriptor only); CVE-2026-4867 was already in the tree.In rhdh-plugins,
app,app-legacy, andbackendare SBOM-excluded.