chore(quickstart): defer NFS UI to async chunks; fix CTA and header blueprints - #4897
Open
lokanandaprabhu wants to merge 4 commits into
Open
lokanandaprabhu wants to merge 4 commits into
lokanandaprabhu wants to merge 4 commits into
Conversation
Address review feedback on the NFS sync optimization: use MUI Button + router Link for CTAs, import GlobalHeaderMenuItemBlueprint from global-header/blueprints to keep markdown/highlight out of the MF async graph, and replace the copied ShapesOutlinedIcon with MUI WidgetsOutlined. Co-authored-by: Cursor <cursoragent@cursor.com>
lokanandaprabhu
requested review from
a team,
divyanshiGupta and
its-mitesh-kumar
as code owners
September 21, 2026 09:12
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Restructure SVG/URL image rendering so CPD no longer matches ScorecardIcon (4.4% → under the 3% new-code duplication gate). Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
/hold |
Use the published package that exports the thin blueprints entry so CI resolves the import without a local link. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4897 +/- ##
==========================================
+ Coverage 63.62% 63.63% +0.01%
==========================================
Files 2693 2696 +3
Lines 107215 107243 +28
Branches 29996 30003 +7
==========================================
+ Hits 68215 68244 +29
+ Misses 38494 38492 -2
- Partials 506 507 +1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@backstage/uiCTA (Button/ButtonLink) with MUIButton+react-router-domLink(native<a>for external URLs).GlobalHeaderMenuItemBlueprintfromglobal-header/blueprintsso help-menu registration does not pull the critical header /MarkdownContent/ syntax-highlighter stack into quickstart’s MF async graph.ShapesOutlinedIcon; invalid icons fall back to MUIWidgetsOutlined(Sonar duplication).@red-hat-developer-hub/backstage-plugin-global-headerto^3.1.0(published with the thin/blueprintsexport from chore(global-header): export thin /blueprints menu-item API #4895).Depends on
global-header/blueprintsexport — merged / published as 3.1.0; this PR now depends on that release (no local link required).Relates to
Remount (post CTA +
/blueprints, local)Highlight /
MarkdownContent/@backstage/uiabsent from quickstart async graph after the thin blueprints import.Test plan
yarn startwith@red-hat-developer-hub/backstage-plugin-global-header@^3.1.0from the registry (no--link)