auto-docs: Update Cloud API spec#75
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates two OpenAPI specification files. In cloud-controlplane.yaml, it adds new GCP RPSQL-related properties (rpsql_api_service_account, rpsql_cloud_storage_bucket, rpsql_secret_manager_prefix, rpsql_service_account) to the CustomerManagedResourcesUpdate.GCP schema and rpsql_secret_manager_prefix to the v1 CustomerManagedResources.GCP schema, with documentation describing the Secret Manager resource-path format for Iceberg catalog credentials. In cloud-dataplane.yaml, it changes the summary text of the TransformService_DeployTransform operation from "Deploy transform" to "Deploy Transform". Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ℹ️ Cloud Data Plane API API content change detectedNo structural change, nothing to display. Powered by Bump.sh |
🤖 Cloud Control Plane API API structural change detectedStructural change detailsModified (20)
Powered by Bump.sh |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cloud-dataplane/cloud-dataplane.yaml (1)
7859-7859: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueCasing inconsistent with sibling "Wasm Transforms" summaries.
Other operations under the same tag use lowercase nouns:
List transforms,Delete transform,Get transform. This change makesDeploy Transformthe outlier. If intentional, fine; otherwise revert toDeploy transformfor consistency. Since this file is auto-generated, the actual fix should be applied upstream in thecloudv2source annotation.✏️ Suggested casing fix (apply upstream)
- summary: Deploy Transform + summary: Deploy transform🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cloud-dataplane/cloud-dataplane.yaml` at line 7859, The operation summary for the Deploy action is inconsistent with the other Wasm Transforms summaries, which all use lowercase nouns. Update the upstream `cloudv2` source annotation that generates this OpenAPI entry so `Deploy Transform` becomes `Deploy transform`, keeping it aligned with `List transforms`, `Delete transform`, and `Get transform`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cloud-dataplane/cloud-dataplane.yaml`:
- Line 7859: The operation summary for the Deploy action is inconsistent with
the other Wasm Transforms summaries, which all use lowercase nouns. Update the
upstream `cloudv2` source annotation that generates this OpenAPI entry so
`Deploy Transform` becomes `Deploy transform`, keeping it aligned with `List
transforms`, `Delete transform`, and `Get transform`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 43f7cb1c-50cd-461b-abba-e027a4f1ab9c
📒 Files selected for processing (2)
cloud-controlplane/cloud-controlplane.yamlcloud-dataplane/cloud-dataplane.yaml
3f0b231 to
61c8ecb
Compare
This PR updates the OpenAPI spec file for the Cloud API.
Triggered by commit: 793070d9fa84a649f97d3c4c8c841897456f0f5a