UX-1469: fix breadcrumb navigation while topic messages are loading - #2641
Merged
Conversation
Clicking the current topic's own breadcrumb re-navigated to its bare path, dropping query params (filters, pagination, active tab); it now renders as non-navigable text instead. Clicking the "Topics" breadcrumb while a message search is in flight could race a queued nuqs URL update and land on /topics/undefined; the topic details route now redirects that back to /topics. Also hardens error-message handling in the message search and the default route error boundary so a non-Error rejection never renders the literal text "undefined".
Contributor
✅ Clean — no registry drift, off-token colours, or ad-hoc classesApp:
Generated by lookout audit-changes. |
SpicyPete
approved these changes
Sep 10, 2026
SpicyPete
left a comment
SpicyPete
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good, Claude is flagging some issues, but they are mostly around the old security page.
Can the older security page be merged soonish to simplify things?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nuqsURL update: the update flushes ~50-90ms later using a now-stale relative route match, and TanStack Router silently interpolates the literal string"undefined"into the path, landing on/topics/undefined(404). The topic details route now guards againsttopicName === 'undefined'and redirects back to/topics.Tab.Messages/index.tsx) and the default route error boundary (route-error.tsx) so a non-Errorrejection never renders the literal textundefinedto the user.Test plan
bun run type:checkbun run lintbun run test:integration -- components/layout/headerbun run test:integration -- route-errorbun run test:integration -- topics/\$topicNamebun run test:integration -- Tab.Messages