Repository navigation
fix: keep view:cache working without the panel builder - #205
Open
nessimabadi wants to merge 1 commit into
Open
nessimabadi wants to merge 1 commit into
nessimabadi wants to merge 1 commit into
Conversation
The board page view renders <x-filament-panels::page>, so compiling the flowforge view namespace failed in apps that use InteractsWithBoard without filament/filament. Move it to resources/panel-views and only register that path when Filament Panels is installed. Fixes relaticle#204 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nessimabadi
force-pushed
the
fix/view-cache-without-panels
branch
from
October 16, 2026 18:20
bf10ee3 to
556edc5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Problem
php artisan view:cache(andphp artisan optimize) fails in apps that use Flowforge withoutfilament/filament:view:cachecompiles every view in every registered namespace.flowforge::filament.pages.board-pagerenders<x-filament-panels::page>, which only exists when the Panel Builder is installed. Since #86 the Panel Builder is only a suggested dependency.Fix
board-page.blade.phpfromresources/viewstoresources/panel-views, keeping the same relative path.FlowforgeServiceProvider::packageBooted(), addresources/panel-viewsto theflowforgeview namespace and to theflowforge-viewspublish tag only whenFilament\Panelexists, the same checkfilament/supportuses to detect the Panel Builder.The view name stays
flowforge::filament.pages.board-page, soBoardPage,BoardResourcePageandBaseBoardneed no changes. Published overrides inresources/views/vendor/flowforgestill take precedence.Tests
ServiceProviderTest: no view underresources/viewsmay referencefilament-panels::components. It fails on4.xand passes with this change.flowforge::filament.pages.board-pagestill resolves when Panels is installed passes.filament/formsandfilament/tablesbut nofilament/filament:view:cachefails on v4.1.4 and succeeds with this change.composer analysereports 7 errors on4.x, all in files this PR doesn't touch.🤖 Generated with Claude Code