Skip to content

fix(rules): preserve equals signs in query parameter values #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jashkarangiya wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −2
Open

fix(rules): preserve equals signs in query parameter values #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions common/rule-processor/tests/processors/QueryParamsRuleProcessor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,26 @@ describe("QueryParamsRuleProcessor:", function () {
).toBe(URL_SOURCES.EXAMPLE + "?b=2");
});

it("should preserve equals signs in existing query param values", function () {
const addModification = {
type: CONSTANTS.MODIFICATION_TYPES.ADD,
param: "added",
value: "2",
};
const removeModification = {
type: CONSTANTS.MODIFICATION_TYPES.REMOVE,
param: "remove",
};
const url = URL_SOURCES.EXAMPLE + "?token=abc==&remove=1";

expect(QueryParamsRuleProcessor.applyQueryParamModifications([addModification], url)).toBe(
URL_SOURCES.EXAMPLE + "?token=abc==&remove=1&added=2"
);
expect(QueryParamsRuleProcessor.applyQueryParamModifications([removeModification], url)).toBe(
URL_SOURCES.EXAMPLE + "?token=abc=="
);
});

it("add and remove param should not create any effect", function () {
var modifications = queryParamsRule.pairs[0]["modifications"];

Expand Down
5 changes: 3 additions & 2 deletions common/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,9 @@ export function getQueryParamsMap(queryString) {
queryParams = queryString.split("&");

queryParams.forEach(function (queryParam) {
var paramName = queryParam.split("=")[0],
paramValue = queryParam.split("=")[1];
var separatorIndex = queryParam.indexOf("="),
paramName = separatorIndex === -1 ? queryParam : queryParam.slice(0, separatorIndex),
paramValue = separatorIndex === -1 ? undefined : queryParam.slice(separatorIndex + 1);

// We are keeping value of param as array so that in future we can support multiple param values of same name
// And we do not want to lose the params if url already contains multiple params of same name
Expand Down