refactor: establish CSSFontLoading folder feature - #318
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
2 times, most recently
from
August 5, 2026 12:14
93c479b to
cbc998e
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
3 times, most recently
from
August 5, 2026 13:40
ceffe7c to
d4373fd
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 5, 2026 13:57
d4373fd to
5fe4b3c
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
3 times, most recently
from
August 5, 2026 14:50
fe56d0e to
f2e85d6
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
2 times, most recently
from
August 5, 2026 15:45
5aa9ce8 to
c6013db
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 5, 2026 17:39
c6013db to
7e9c37a
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 6, 2026 14:52
7e9c37a to
3626b9d
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 6, 2026 14:58
3626b9d to
e57477d
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
2 times, most recently
from
August 6, 2026 17:19
0103364 to
767572f
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
2 times, most recently
from
August 6, 2026 20:09
6c76141 to
5220698
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 6, 2026 20:50
5220698 to
3a38a56
Compare
jderochervlk
force-pushed
the
codex/option5-css-font-loading-folder
branch
from
August 6, 2026 20:58
3a38a56 to
7e0470c
Compare
fhammerschmidt
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 8 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #317.
Summary
src/CSSFontLoadingto the targetsrc/css-font-loadingfolderBaseCSSFontLoadingout ofcoreand into its owning complete folderCSSFontLoadingfeatureWebAPI.CSSFontLoadingfeature with itsWebAPI.EventdependencyWebAPI.FontFaceandWebAPI.FontFaceSetpublic modulesTemporary state
BaseCSSFontLoadingplacement documented in refactor: establish DOM core folder #311BaseCSSFontLoadingandCssFontLoadingTypesaggregation remains inside the correct folder; any final type colocation is deferred to cleanupReview focus
WebAPI.CSSFontLoading -> WebAPI.Event + CSSFontLoadingimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,CSSFontLoadingnpm run buildnpm testnpm run format:checkgit diff --check