Repository navigation
Conversation
🦋 Changeset detectedLatest commit: bab4857 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@hsusul is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3801.
Gradients, shadow/ring colors,
blur-*,drop-shadow-*andtranslate-*with theme values inlinedvar(--color-…)/var(--spacing), which email clients drop because nothing defines them. Arbitrary values and direct utilities were fine. The broken ones go through Tailwind's--tw-*variables.resolveAllCssVariableshad two gaps:var()inside custom property values, so--tw-gradient-from: var(--color-red-500)was never resolved against:root. css-tree parses custom property values asRaw, so they're parsed as values before walking.filter: var(--tw-blur,), got the unresolved text. Replacements now read the definition's current value.A
var()inside a custom property that has no matching definition keeps its fallback. Another class on the element may still define it at inline time. For example,shadow-red-500sets--tw-shadow-colorforshadow-md's--tw-shadow. Substituting the fallback early would break that.Most of the diff in
resolve-all-css-variables.tsis re-indentation from dropping theelse. Use?w=1to see the real change.Not addressed:
shadow-black/20still leaves acolor-mix(in oklab, rgb(0,0,0,0.2) 100%, transparent)after resolution. That's a separatecolor-mixdownleveling issue.Tests
var()inside custom property definitions and the stale-definition case (--tw-blur).<Tailwind>render test covering a three-stop theme gradient, themeshadow-*/ring-*colors,blur-smandtranslate-x-2, which asserts novar(in the output.canaryand pass with the fix. No existing snapshot changed.pnpm testinpackages/react-email(316 passed),pnpm typecheckandpnpm lintall pass locally.This doesn't conflict with #3795, which touches the same file: it applies cleanly on top, and the Tailwind tests pass with both.