Repository navigation
Conversation
馃 Changeset detectedLatest commit: 63f0f50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@hsusul is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3802.
convertToPxreturned0forpt, andButtonwrites the converted longhands after the user'spadding, sopadding: '9pt 15pt'(orpx-[15pt] py-[9pt]) rendered a button with no padding in any client and zeroed the Outlook spacers.This adds
ptto the unitsconvertToPxhandles (1pt = 4/3px). That keeps the existing approach of converting padding topx, and9pt 15ptnow renders the same as12px 20px.Units that still have no px equivalent here (
calc(),var(), viewport units) are left as they were.Tests
convertToPx('9pt')unit test and a render test asserting the longhands and the Outlook spacer values. Both fail oncanary.pnpm testinpackages/react-email(316 passed),pnpm typecheckandpnpm lintall pass locally.It touches the same file as #3793 but not the same lines; #3793 applies cleanly on top.