Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/dialog/server_dialog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,16 @@ impl ServerInviteDialog {
/// * `Err(Error)` - Failed to build/send BYE request.
pub async fn bye_with_headers(&self, headers: Option<Vec<crate::sip::Header>>) -> Result<()> {
if !self.inner.is_confirmed() && !self.inner.waiting_ack() {
// Silent success here is a footgun for B2BUA hangup paths: callers
// cannot tell BYE was never sent. Log when we skip so operators can
// correlate stuck endpoints with dialog state divergence.
if !self.inner.is_terminated() {
warn!(
id = %self.id(),
state = %self.state(),
"bye skipped: dialog not Confirmed/WaitAck"
);
}
return Ok(());
}

Expand Down