feat: allow overriding the address advertised in Record-Route - #140
Open
kneliba wants to merge 1 commit into
Open
feat: allow overriding the address advertised in Record-Route#140kneliba wants to merge 1 commit into
kneliba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_record_routealways builds the URI from the first entry oftransport_layer.get_addrs()and a proxy can't advertise anything other than its primary listener. It also can't patch it afterwards either as theRecordRouteis built and returned in one callwhy is this a problem?
unprotected port and arrive outside the security association, leaking data that should be encrypted
summary of changes
get_record_routetakes anOption<SipAddr>Nonekeeps current behaviour.examples/proxy.rs) passesNonetest_endpoint.rscovers both paths; build, test and fmt passnote
pub fn, happy to add a separateget_record_route_with_addrinstead if that's preferred.Thanks for your time!