Skip to content

draft: preview mode follow ups#9195

Closed
royendo wants to merge 2 commits into
mainfrom
royendo/preview-mode-route-utils
Closed

draft: preview mode follow ups#9195
royendo wants to merge 2 commits into
mainfrom
royendo/preview-mode-route-utils

Conversation

@royendo

@royendo royendo commented Apr 7, 2026

Copy link
Copy Markdown
Contributor
  1. AppMode enum (replacing string literals)
  2. Centralized route utility functions with tests (all 8 tests passing, full test suite green)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51 nishantmonu51 added on-hold Size:M Medium change: 100-499 lines labels Jun 30, 2026
@nishantmonu51

Copy link
Copy Markdown
Collaborator

closing as its mostly superceeded by #9360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-hold Size:M Medium change: 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants