fix: .env variables pushed to the wrong project when deploy hits a name collision#9699
Open
nishantmonu51 wants to merge 1 commit into
Open
fix: .env variables pushed to the wrong project when deploy hits a name collision#9699nishantmonu51 wants to merge 1 commit into
.env variables pushed to the wrong project when deploy hits a name collision#9699nishantmonu51 wants to merge 1 commit into
Conversation
When the requested project name already exists in the org, CreateProject retries with a numeric suffix (e.g. my-project-1), but the subsequent UpdateProjectVariables call still targeted the originally requested name. The local .env then overwrote the variables of the unrelated pre-existing project, while the newly created project received no variables at all. Use the org and name from the CreateProject response instead, matching what RedeployProject already does.
Collaborator
Author
|
@codex: review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeployProjectretriesCreateProjectwith a numeric suffix (e.g.my-project→my-project-1), but the follow-upUpdateProjectVariablescall still targeted the originally requested name..env(typically connector credentials) overwrote the variables of the unrelated pre-existing project, while the newly created project received no variables at all — so its deployment can't connect to its sources.CreateProject(the project actually created), matching whatRedeployProjectalready does.Checklist: