Require ReadInstance permission in ConnectorService handlers#9700
Open
nishantmonu51 wants to merge 1 commit into
Open
Require ReadInstance permission in ConnectorService handlers#9700nishantmonu51 wants to merge 1 commit into
ReadInstance permission in ConnectorService handlers#9700nishantmonu51 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConnectorServicehandlers (ListBuckets,ListObjects,OLAPListTables,OLAPGetTable,ListDatabaseSchemas,ListTables,GetTable) performed no permission checks, so any caller with a valid JWT for the runtime (or none at all) could enumerate OLAP tables, connector schemas, and object storage contents. All seven now requireReadInstanceon the requested instance.ReadInstancematchesAnalyzeConnectors, the sibling endpoint powering the same connector explorer UI, and is held by every legitimate caller: Rill Developer (auth disabled), the Cloud status page (gated onmanageProject), cloud editing, and the admin service account.ReadOLAPwas not used for the OLAP endpoints because it is only granted on editable deployments, which would break the status page's tables tab on prod.ReadObjectswas not used for the object store endpoints because it is part of every viewer's base grant and would not restrict access.instance_id, the check also prevents using a JWT issued for one instance against another instance on the same runtime.Checklist: