Conversation
versioneer (setup.py: version=versioneer.get_version()) has no env-var pretend-version override, unlike setuptools_scm. It renders the version from `git describe --tags --dirty`, so the patched-but-uncommitted tree came out as 5.0.13+0.g3b4202a.dirty instead of the clean 5.0.13. Commit the patch and force-move the local tag onto it so describe reports the exact tagged version again (0 distance, clean tree).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiglpkUnlike the other version-pin fixes in this series (asv/pynng/uharfbuzz/zlib-ng/nodejs-wheel-binaries/mlx), swiglpk uses
versioneer(notsetuptools_scm), which has no environment-variable pretend-version override. It renders the version fromgit describe --tags --dirty, so the patched-but-uncommitted checkout came out as5.0.13+0.g3b4202a.dirtyinstead of the clean5.0.13.Fix: commit the patch locally and force-move the local
5.0.13tag onto that commit, sogit describereports 0 distance and a clean tree - i.e. exactly5.0.13again.License: OK, unchanged.