Repository navigation
Conversation
mfazekas
force-pushed
the
claude/fix-369-font-picker-gc
branch
from
October 3, 2026 20:03
2d5ae47 to
a85de42
Compare
rive-android stores FontFallbackStrategy.stylePicker in a WeakReference, so the anonymous picker was collected at the next GC and fallback fonts silently stopped working (#369).
mfazekas
force-pushed
the
claude/fix-369-font-picker-gc
branch
from
October 13, 2026 14:30
a85de42 to
4eb9204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rive-android keeps
FontFallbackStrategy.stylePickeronly in aWeakReference(still the case in 11.12.1), andHybridRiveFontConfig.applyFallbackFonts()passed it an anonymous object nothing else held. A GC shortly aftersetFallbackFonts()collected the picker, so text needing a fallback (Thai, Hebrew, Arabic, CJK) rendered blank withFindFontFallback - no fallback found. This keeps a strong reference untilclearFallbackFonts(). Affects both Android runtimes, since the file is shared.Root cause and fix by @edgartoomikw in #369, thanks!
Adds an
Issue369FontPickerGCreproducer page: it sets Kanit as the fallback, loads the font another 250 times to make the Java heap collect, then mounts a view showing Thai text. On the Pixel 6 emulator with rive-android 11.12.1, the text is blank without the fix and renders in Kanit with it.Fixes #369