Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the new backend, onSurfaceTextureSizeChanged now resizes the RiveSurface through a reflective call to the Kotlin-internal RiveSurface.resize (resolved by name prefix and (int, int) signature, cached), mirroring what upstream RiveView does. It fails open: if the method is missing or throws, it logs a warning and keeps the old size. Fit.Layout resizes are also followed by a zero advance, since the render loop stops advancing a settled or paused state machine and the artboard resize would otherwise never apply. Adds an Issue #418 reproducer page.
Fixes #418