Prevent SQLite driver from adding nil placeholders for missing jobs#1312
Open
brandur wants to merge 1 commit into
Open
Prevent SQLite driver from adding nil placeholders for missing jobs#1312brandur wants to merge 1 commit into
nil placeholders for missing jobs#1312brandur wants to merge 1 commit into
Conversation
This one's a follow up to #1308 which modifies the completers to handle a rare condition where no rows are returned from `JobSetStateIfRunningMany`. Codex caught it while I was looking at the other PR. Here, also modify `JobSetStateIfRunningMany` in the SQLite driver so that if a job is missing from query return, in omits the element completely instead of adding a `nil` element in the return slice, bringing its behavior in line with Postgres. We add a check in the driver test suite to verify the consistent behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one's a follow up to #1308 which modifies the completers to handle
a rare condition where no rows are returned from
JobSetStateIfRunningMany.Codex caught it while I was looking at the other PR.
Here, also modify
JobSetStateIfRunningManyin the SQLite driver sothat if a job is missing from query return, in omits the element
completely instead of adding a
nilelement in the return slice,bringing its behavior in line with Postgres. We add a check in the
driver test suite to verify the consistent behavior.