Skip to content

Fix intermittent test TestProducer_PollOnly/JobStuckHandlerOpensExecutorSlot #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Jul 17, 2026
Merged

Fix intermittent test TestProducer_PollOnly/JobStuckHandlerOpensExecutorSlot #1313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion producer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,11 @@ func testProducer(t *testing.T, makeProducer func(ctx context.Context, t *testin
handlerParamsCh := make(chan JobStuckHandlerParams, 2)
producer.config.JobStuckHandler = func(ctx context.Context, params JobStuckHandlerParams) JobStuckHandlerResult {
handlerParamsCh <- params
return JobStuckHandlerResult{AddWorkerSlot: true}

// Only replace the first stuck job. The second job may also pass the
// short test timeout before the assertion runs on a busy machine, but
// it should continue occupying its executor slot in that case.
return JobStuckHandlerResult{AddWorkerSlot: params.TotalStuckJobs == 1}
}

var (
Expand Down
Loading