Skip to content

Fix intermittent test Test_Client_JobContextInheritsFromProvidedContext #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Jul 17, 2026
+2 −7
Merged

Fix intermittent test Test_Client_JobContextInheritsFromProvidedContext #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2804,19 +2804,14 @@ func Test_Client_JobContextInheritsFromProvidedContext(t *testing.T) {
ctx = context.WithValue(ctx, customContextKey("BestGoPostgresQueue"), "River")
client := runNewTestClient(ctx, t, config)

insertCtx, insertCancel := context.WithTimeout(ctx, time.Second)
insertCtx, insertCancel := context.WithTimeout(ctx, riversharedtest.WaitTimeout())
t.Cleanup(insertCancel)

// enqueue job:
_, err := client.Insert(insertCtx, callbackWithCustomTimeoutArgs{TimeoutValue: 5 * time.Minute}, nil)
require.NoError(t, err)

var jobCtx context.Context
select {
case jobCtx = <-jobCtxCh:
case <-time.After(5 * time.Second):
t.Fatal("timed out waiting for job to start")
}
jobCtx := riversharedtest.WaitOrTimeout(t, jobCtxCh)

require.Equal(t, "River", jobCtx.Value(customContextKey("BestGoPostgresQueue")), "job should persist the context value from the client context")
jobDeadline, ok := jobCtx.Deadline()
Expand Down
Loading