fix(effect): forward all RivetKit actor options, not just name and icon - #5591
Open
AuthorOfTheSurf wants to merge 2 commits into
Open
fix(effect): forward all RivetKit actor options, not just name and icon#5591AuthorOfTheSurf wants to merge 2 commits into
AuthorOfTheSurf wants to merge 2 commits into
Conversation
AuthorOfTheSurf
marked this pull request as ready for review
August 27, 2026 05:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was observing an actor that awaits an LLM gets killed by the 60s default
actionTimeoutand there was no way to raise it — the option is accepted by the type system and then discardednameandiconget passed through. The intent of this PR is to properly pass through all config keysActorOptionsSchemais .strict())intact when unset, and SDK-only options (state/db) kept out of the forwarded bag.
The change
Eight lines of source. Rather than widen the allowlist, I inverted the split: