Skip to content

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert - #5604

Open
abcxff wants to merge 1 commit into
mainfrom
stack/fix-rivetkit-napi-remove-stale-httprequestbodystream-test-after-envoy-v6-revert-rlmrkmtk
Open

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert#5604
abcxff wants to merge 1 commit into
mainfrom
stack/fix-rivetkit-napi-remove-stale-httprequestbodystream-test-after-envoy-v6-revert-rlmrkmtk

Conversation

@abcxff

@abcxff abcxff commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/actors

Get stack: forklift get 5604
Push local edits: forklift submit
Merge when ready: forklift merge 5604

change rlmrkmtk

@railway-app

railway-app Bot commented Aug 25, 2026

Copy link
Copy Markdown

🚅 Deployed to the actors-pr-5604 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink 😴 Sleeping (View Logs) Web Aug 25, 2026 at 7:39 pm
frontend-cloud 😴 Sleeping (View Logs) Web Aug 25, 2026 at 7:38 pm
frontend-inspector 😴 Sleeping (View Logs) Web Aug 25, 2026 at 7:34 pm
ladle ✅ Success (View Logs) Web Aug 25, 2026 at 7:30 pm
mcp-hub ✅ Success (View Logs) Web Aug 25, 2026 at 7:28 pm
website ❌ Build Failed (View Logs) Web Aug 25, 2026 at 7:27 pm

@claude

claude Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review

Small, correct cleanup. Verified via repo-wide grep that HttpRequestBodyStream no longer exists anywhere in the codebase (napi crate or rivetkit-core), so cancelling_http_request_body_drops_core_receiver would not compile after the envoy v6 revert removed the type — deleting it is the right call rather than trying to keep it alive with a shim.

Code quality: Good. The now-unused imports (HttpRequestBodyStream, CoreHttpRequestBodyStream, tokio::sync::{mpsc, watch}) are removed alongside the test, and the remaining imports (Mutex, RivetErrorSchema, MacroMarker, Level, MakeWriter, parse_bridge_rivet_error, etc.) are still used by the other tests in the file, so nothing is left dangling.

Test coverage: This does remove the only coverage for "cancelling an in-flight HTTP request body stream drops the core-side receiver." Since that's a real behavior worth protecting against regressions, if the underlying HttpRequestBodyStream type/functionality comes back in a future change (e.g. envoy v6 re-lands), it'd be worth re-adding an equivalent test at that point rather than letting the coverage gap persist silently.

Bugs/security/performance: None applicable — this is a pure test deletion with no production code changes.

No blocking issues; looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant