You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my use case, Id like to cancel a Queue and get rid of all the items within the queue, but without throwing the QueueCancelledException. A so called 'silent' cancel.
Here I've added an option supressErrorsOnCancel which defaults to false so it doesn't do any breaking changes
But if its true then instead of doing a .completeError it will just do a .complete
This is the part I'm unsure if it's going to function as intended. In my own use case this seems to be working just fine. But please review if you think it should be merged in.
Essentially, I'm expecting that it will just close out the queue item with a .complete without actually executing the queue item. If its not working like that then please feel free to reject this PR
So I have no problem with a silent cancel, I guess my only foreseeable problems would be around maintaining null safety when its completed, and perhaps memory leaks. I'll need to dig into the code to ensure both of those wont be an issue - but realistically if your PR has all the tests passing, the memory leak and null safety issues are probably already existing in the code and haven't been thought about anyway.
So I have no problem with a silent cancel, I guess my only foreseeable problems would be around maintaining null safety when its completed, and perhaps memory leaks. I'll need to dig into the code to ensure both of those wont be an issue - but realistically if your PR has all the tests passing, the memory leak and null safety issues are probably already existing in the code and haven't been thought about anyway.
Sounds great-- mainly I'm concerned that by putting in .complete, it doesn't go ahead and execute the queue item. Hopefully you don't see that happening on your end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my use case, Id like to cancel a Queue and get rid of all the items within the queue, but without throwing the
QueueCancelledException. A so called 'silent' cancel.Here I've added an option
supressErrorsOnCancelwhich defaults tofalseso it doesn't do any breaking changesBut if its true then instead of doing a
.completeErrorit will just do a.completeThis is the part I'm unsure if it's going to function as intended. In my own use case this seems to be working just fine. But please review if you think it should be merged in.
Essentially, I'm expecting that it will just close out the queue item with a
.completewithout actually executing the queue item. If its not working like that then please feel free to reject this PR