Fix C parser compiler warnings - #5721
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C parser currently declares and defines several no-argument functions using empty parameter lists:
In C,
()leaves the parameters unspecified and GCC reports these definitions with -Wold-style-definition:The parser's
yyerrorfunction always raises throughrb_exc_raise, but it is not declared as non-returning, which produces an additional compiler warning.This PR updates the no-argument declarations and definitions to use
(void)and marksyyerrorwith Ruby's portableNORETURNmacro. The Ragel and Bison source files and their generated C files are updated together.There is no runtime behavior change.