Skip to content

fix(android): defer startup camera change events #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobJacobson wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(android): defer startup camera change events #4355

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
788e9c2
fix(android): defer initial camera events until defaults are applied
RobJacobson Oct 13, 2026
cd0f67c
fix(android): gate initial camera change events
RobJacobson Oct 13, 2026
ccbd919
refactor(android): isolate initial camera event gating
RobJacobson Oct 13, 2026
edb1099
test(android): cover camera change event readiness
RobJacobson Oct 13, 2026
aa3161f
refactor(android): inline startup camera event buffering
RobJacobson Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,27 @@ open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapVie

private var wasGestureActive = false
private var isGestureActive = false
private val startupCameraEvents = object {
private var isReady = false
private var hasPendingChange = false

fun onCameraChanged() {
if (!isReady) {
hasPendingChange = true
return
}
sendCameraChangedEvents()
}

fun markReady() {
if (isReady) return
isReady = true
if (hasPendingChange) {
hasPendingChange = false
sendCameraChangedEvents()
}
}
}

var mapViewImpl: String? = null

Expand Down Expand Up @@ -260,8 +281,7 @@ open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapVie
val _this = this

map.addOnCameraChangeListener(OnCameraChangeListener { cameraChangedEventData ->
handleMapChangedEvent(EventTypes.REGION_IS_CHANGING)
handleMapChangedEvent(EventTypes.CAMERA_CHANGED)
startupCameraEvents.onCameraChanged()
})

map.addOnMapIdleListener(OnMapIdleListener { mapIdleEventData ->
Expand Down Expand Up @@ -856,6 +876,11 @@ open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapVie

// region Events

private fun sendCameraChangedEvents() {
handleMapChangedEvent(EventTypes.REGION_IS_CHANGING)
handleMapChangedEvent(EventTypes.CAMERA_CHANGED)
}

fun sendRegionDidChangeEvent() {
handleMapChangedEvent(EventTypes.REGION_DID_CHANGE)
mCameraChangeTracker.setReason(CameraChangeReason.NONE)
Expand Down Expand Up @@ -1622,6 +1647,8 @@ open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapVie
super.onAttachedToWindow()
Handler(Looper.getMainLooper()).post {
lifecycle.afterAttachFromLooper()
// Camera.addToMap applies defaultSettings in the attach callbacks (#4213).
startupCameraEvents.markReady()
}
}

Expand Down