Repository navigation
feat(redis): add redis.v1 RPC messages - #82
Merged
Merged
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
This reverts commit 87c5b87. The connection field names the KV storage that provides the Redis client. Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
roadrunner-server/roadrunner#1195: the KV plugin exposes only the generic get, set, has, delete and TTL operations, so there is no race-safe way to run Redis-native commands such as
INCRBYfrom PHP. This PR adds the message definitions for aredis.*RPC service exposed by the redis plugin.Description of Changes
roadrunner/api/redis/v1/redis.protowith theredis.v1package: one request message per command for strings and counters, keys, hashes, lists, sets and sorted sets, and a small set of shared reply messages (IntReply,BytesReply,BytesListReply,MapReply,ScoredMembersReply,ScanReplyand others).connectionfield that selects a named connection from the plugin'sredisconfig section. Nil replies are modelled withoptionalfields, so a missing key is data and not an error.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md.