Repository navigation
Automate moderation and merge of clean bot submissions - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot submissions currently wait for the sole human moderator even when they are routine. This adds a trusted first-level moderation workflow: it checks one bot directory, screens source and dependencies, completes a one-round battle in a constrained container, then lets a repository-scoped GitHub App approve and merge only the tested head SHA. Failed bots receive a changes-requested review; uncertain and non-bot changes go to Flemming with a reason and a pending required status. Catalog publication verifies the successful moderation status after merge.
The App, secrets, Actions event allowance, and required
bot-moderationbranch rule must be configured and tested before this workflow is active. The App must not have a branch-rule bypass.github-actions[bot]needs a bypass for the trusted catalog publisher's generated-file push; Flemming needs a pull-request-only bypass for policy PRs he authors, since authors cannot approve their own PRs.Validation: 39 Python tests pass (2 existing runtime-dependent skips); actionlint passes; a completed one-round battle passed for official Java, Python, C#, and TypeScript starters, and historical new-bot PR #12 and version-update PR #14 passed the complete assessor locally.