Repository navigation
Conversation
The method saved every download as weights.pt, also when the API served an ONNX or safetensors artifact. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
mkaic
marked this pull request as ready for review
November 11, 2026 22:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Code and PR description are LLM-written. If this PR has been marked Ready For Review, code has
been reviewed and tested in staging by Kai
Diff breakdown
Description
TrainedModel.download()always saved the downloaded file asweights.pt. The API serves some models in a different format, for examplemodel.safetensorsorweights.onnx. For those models, the file on disk had the wrong extension.Now the method reads the extension from the signed URL that the API returns. The file name is
weightsplus that extension. If the URL has no extension, the method uses.pt.A model that the API serves as a
.ptfile still saves asweights.pt. This includesbest.ptfor classification models. Theformatargument does not change and accepts only"pt".Testing
Pending.
🤖 Generated with Claude Code