Skip to content

Fix verifier version check - #1217

Merged
0xfornax merged 1 commit into
masterfrom
verifier-selector
Sep 10, 2026
Merged

0xfornax merged 1 commit into
masterfrom
verifier-selector

Conversation

@0xfornax

@0xfornax 0xfornax commented Sep 10, 2026

Copy link
Copy Markdown
Member

Correctly switch between proof versions used on 1.4.0 and 1.4.1 contracts. Also keeping track of when to craft proof as v1 (pre-Gloas) or v2 (post-Gloas).

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/bindings/legacy/v1.4.0/megapool 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/megapool 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/megapool 0.06% (+0.00%) 👍
github.com/rocket-pool/smartnode/rocketpool/api/megapool 0.08% (+0.00%) 👍
github.com/rocket-pool/smartnode/rocketpool/node 0.52% (-0.00%) 👎
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.76% (+0.00%) 👍
github.com/rocket-pool/smartnode/shared/services 0.45% (-0.02%) 👎
github.com/rocket-pool/smartnode/shared/services/beacon 8.46% (-0.13%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/bindings/legacy/v1.4.0/megapool/megapool-manager.go 0.00% (ø) 521 (+521) 0 521 (+521)
github.com/rocket-pool/smartnode/bindings/megapool/beacon-state-verifier.go 0.00% (ø) 490 (+76) 0 490 (+76)
github.com/rocket-pool/smartnode/rocketpool-cli/megapool/notify-final-balance.go 0.00% (ø) 3905 (-66) 0 3905 (-66)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/dissolve-with-proof.go 0.00% (ø) 3177 (-154) 0 3177 (-154)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/notify-final-balance.go 0.00% (ø) 3171 0 3171
github.com/rocket-pool/smartnode/rocketpool/api/megapool/notify-validator-exit.go 0.00% (ø) 3891 (-150) 0 3891 (-150)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/stake.go 0.00% (ø) 3227 (-154) 0 3227 (-154)
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-exit.go 0.00% (ø) 2967 (-74) 0 2967 (-74)
github.com/rocket-pool/smartnode/rocketpool/node/notify-final-balance.go 0.00% (ø) 3590 (+291) 0 3590 (+291)
github.com/rocket-pool/smartnode/rocketpool/node/notify-validator-exit.go 0.00% (ø) 3701 (-74) 0 3701 (-74)
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 3365 (-74) 0 3365 (-74)
github.com/rocket-pool/smartnode/rocketpool/watchtower/dissolve-invalid-credentials.go 0.00% (ø) 2539 (-100) 0 2539 (-100)
github.com/rocket-pool/smartnode/shared/services/beacon/final_balance.go 0.00% (ø) 125 (+125) 0 125 (+125)
github.com/rocket-pool/smartnode/shared/services/megapool-proofs.go 0.00% (ø) 1863 (+1863) 0 1863 (+1863)
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.58% (-0.01%) 21204 (+380) 124 21080 (+380) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax
0xfornax merged commit 954c9f1 into master Sep 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant