Skip to content

Fix executeUpgradeHandler ID parsing and error response #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xfornax merged 1 commit into from
Sep 11, 2026
+4 −4
Merged

Fix executeUpgradeHandler ID parsing and error response #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rocketpool/api/upgrade/execute-upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@ func executeUpgrade(c *cli.Command, upgradeProposalId uint64, t *snroute.Transac
}

func canExecuteUpgradeHandler(ctx snroute.Context) {
id, err := cliutils.ValidatePositiveUint("upgrade proposal ID", ctx.Request.URL.Query().Get("id"))
id, err := cliutils.ValidatePositiveUint("upgrade proposal ID", ctx.Request.FormValue("id"))
if err != nil {
response.WriteResponse(ctx.Writer, nil, err)
response.WriteErrorResponse(ctx.Writer, err)
return
}
resp, err := canExecuteUpgrade(ctx.Command(), id)
response.WriteResponse(ctx.Writer, resp, err)
}

func executeUpgradeHandler(ctx snroute.WriteContext) {
id, err := strconv.ParseUint(ctx.Request.URL.Query().Get("id"), 10, 64)
id, err := strconv.ParseUint(ctx.Request.FormValue("id"), 10, 64)
if err != nil {
response.WriteResponse(ctx.Writer, nil, err)
response.WriteErrorResponse(ctx.Writer, err)
return
}
opts, err := ctx.Transactor()
Expand Down
Loading