Skip to content

Fix node metrics collector blanking on missing rewards tree files #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xfornax merged 1 commit into from
Sep 11, 2026
+5 −3
Merged

Fix node metrics collector blanking on missing rewards tree files #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rocketpool/node/collectors/node-collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ func (collector *NodeCollector) Collect(channel chan<- prometheus.Metric) {
}

if !previousInterval.TreeFileExists {
return fmt.Errorf("Error retrieving previous interval's total node weight: rewards file %s doesn't exist for interval %d", previousInterval.TreeFilePath, previousRewardIndex)
collector.logError(fmt.Errorf("Error retrieving previous interval's total node weight: rewards file %s doesn't exist for interval %d", previousInterval.TreeFilePath, previousRewardIndex))
}

if previousInterval.TotalNodeWeight != nil {
Expand All @@ -538,7 +538,8 @@ func (collector *NodeCollector) Collect(channel chan<- prometheus.Metric) {
return err
}
if !intervalInfo.TreeFileExists {
return fmt.Errorf("Error calculating lifetime node rewards: rewards file %s doesn't exist but interval %d was claimed", intervalInfo.TreeFilePath, claimedInterval)
collector.logError(fmt.Errorf("Error calculating lifetime node rewards: rewards file %s doesn't exist but interval %d was claimed", intervalInfo.TreeFilePath, claimedInterval))
continue
}

newRewards.Add(newRewards, &intervalInfo.CollateralRplAmount.Int)
Expand All @@ -553,7 +554,8 @@ func (collector *NodeCollector) Collect(channel chan<- prometheus.Metric) {
return err
}
if !intervalInfo.TreeFileExists {
return fmt.Errorf("Error calculating lifetime node rewards: rewards file %s doesn't exist and interval %d is unclaimed", intervalInfo.TreeFilePath, unclaimedInterval)
collector.logError(fmt.Errorf("Error calculating lifetime node rewards: rewards file %s doesn't exist and interval %d is unclaimed", intervalInfo.TreeFilePath, unclaimedInterval))
continue
}
if intervalInfo.NodeExists {
unclaimedRplWei.Add(unclaimedRplWei, &intervalInfo.CollateralRplAmount.Int)
Expand Down
Loading