Skip to content

Add Saturn-2 performance challenge and exit-request handling - #1223

Open
0xfornax wants to merge 34 commits into
masterfrom
defend-performance-challenge
Open

0xfornax wants to merge 34 commits into
masterfrom
defend-performance-challenge

Conversation

@0xfornax

Copy link
Copy Markdown
Member

No description provided.

Master split reconstructed indexes off NetworkState. Pass NetworkStateIndex into the new defend/exit-request tasks so they compile against the refactored state.
@0xfornax
0xfornax force-pushed the defend-performance-challenge branch from e45d960 to 338757f Compare September 14, 2026 19:49
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (14 decrease, 5 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/bindings/megapool 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/minipool 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/network 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/settings/protocol 0.26% (-0.11%) 👎
github.com/rocket-pool/smartnode/bindings/settings/security 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/utils 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/cli/verify-performance 1.14% (+1.14%) 👍
github.com/rocket-pool/smartnode/rocketpool-cli/megapool 0.06% (-0.01%) 👎
github.com/rocket-pool/smartnode/rocketpool-cli/minipool 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao 0.09% (-0.00%) 👎
github.com/rocket-pool/smartnode/rocketpool-cli/security 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/api/megapool 0.07% (-0.01%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/minipool 0.10% (-0.01%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/pdao 0.11% (-0.01%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/security 0.07% (-0.09%) 👎
github.com/rocket-pool/smartnode/rocketpool/node 0.36% (-0.16%) 👎
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.70% (-0.06%) 👎
github.com/rocket-pool/smartnode/shared/services 0.57% (+0.12%) 👍
github.com/rocket-pool/smartnode/shared/services/beacon 7.76% (-0.89%) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client 0.39% (-0.03%) 👎
github.com/rocket-pool/smartnode/shared/services/performance 0.75% (+0.75%) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool 0.00% (ø)
github.com/rocket-pool/smartnode/shared/services/state 4.38% (-0.39%) 👎
github.com/rocket-pool/smartnode/shared/types/api 3.66% (-0.28%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2 0.80% (-0.13%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb 2.91% (-0.23%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu 0.70% (+0.70%) 👍
github.com/rocket-pool/smartnode/shared/types/eth2/fork/gloas 1.88% (-0.13%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/generic 1.89% (+0.04%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/bindings/megapool/megapool-constructor.go 0.00% (ø) 114 (+114) 0 114 (+114)
github.com/rocket-pool/smartnode/bindings/megapool/megapool-contract-v2.go 0.00% (ø) 234 (+234) 0 234 (+234)
github.com/rocket-pool/smartnode/bindings/megapool/megapool-contract.go 0.00% (ø) 5145 (+592) 0 5145 (+592)
github.com/rocket-pool/smartnode/bindings/megapool/performance.go 0.00% (ø) 796 (+796) 0 796 (+796)
github.com/rocket-pool/smartnode/bindings/minipool/minipool-constructor.go 0.00% (ø) 359 (+72) 0 359 (+72)
github.com/rocket-pool/smartnode/bindings/minipool/minipool-contract-v4.go 0.00% (ø) 5446 (+5446) 0 5446 (+5446)
github.com/rocket-pool/smartnode/bindings/network/exit.go 0.00% (ø) 2982 (+2982) 0 2982 (+2982)
github.com/rocket-pool/smartnode/bindings/settings/protocol/exit.go 0.00% (ø) 501 (+501) 0 501 (+501)
github.com/rocket-pool/smartnode/bindings/settings/protocol/megapool.go 0.00% (ø) 1086 (+338) 0 1086 (+338)
github.com/rocket-pool/smartnode/bindings/settings/protocol/performance.go 0.00% (ø) 729 (+729) 0 729 (+729)
github.com/rocket-pool/smartnode/bindings/settings/protocol/setting-types.go 12.36% (-3.67%) 275 (+63) 34 241 (+63) 👎
github.com/rocket-pool/smartnode/bindings/settings/security/performance.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/rocket-pool/smartnode/bindings/utils/version-checker.go 0.00% (ø) 498 (+415) 0 498 (+415)
github.com/rocket-pool/smartnode/rocketpool-cli/cli/verify-performance/verify-performance.go 1.14% (+1.14%) 2273 (+2273) 26 (+26) 2247 (+2247) 👍
github.com/rocket-pool/smartnode/rocketpool-cli/megapool/commands.go 0.00% (ø) 2912 (+518) 0 2912 (+518)
github.com/rocket-pool/smartnode/rocketpool-cli/megapool/verify-performance.go 0.00% (ø) 2352 (+2352) 0 2352 (+2352)
github.com/rocket-pool/smartnode/rocketpool-cli/minipool/commands.go 0.00% (ø) 1795 (+285) 0 1795 (+285)
github.com/rocket-pool/smartnode/rocketpool-cli/minipool/verify-performance.go 0.00% (ø) 1020 (+1020) 0 1020 (+1020)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/commands.go 0.00% (ø) 16567 (+2881) 0 16567 (+2881)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/get-settings.go 0.00% (ø) 29386 (-2040) 0 29386 (-2040)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/propose-settings.go 0.00% (ø) 5660 (+970) 0 5660 (+970)
github.com/rocket-pool/smartnode/rocketpool-cli/security/commands.go 0.00% (ø) 3853 (+431) 0 3853 (+431)
github.com/rocket-pool/smartnode/rocketpool-cli/security/propose-settings.go 0.00% (ø) 1537 (+162) 0 1537 (+162)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/challenge-performance.go 0.00% (ø) 3118 (+3118) 0 3118 (+3118)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/routes.go 2.23% (-1.57%) 1745 (+800) 39 (+3) 1706 (+797) 👎
github.com/rocket-pool/smartnode/rocketpool/api/megapool/verify-performance.go 0.00% (ø) 2681 (+2681) 0 2681 (+2681)
github.com/rocket-pool/smartnode/rocketpool/api/minipool/routes.go 6.56% (-0.97%) 915 (+144) 60 (+2) 855 (+142) 👎
github.com/rocket-pool/smartnode/rocketpool/api/minipool/verify-performance.go 0.00% (ø) 2210 (+2210) 0 2210 (+2210)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/get-settings.go 0.00% (ø) 10528 (+1993) 0 10528 (+1993)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/propose-settings.go 0.00% (ø) 31544 (+5506) 0 31544 (+5506)
github.com/rocket-pool/smartnode/rocketpool/api/security/propose-settings.go 0.00% (ø) 6864 (+852) 0 6864 (+852)
github.com/rocket-pool/smartnode/rocketpool/node/check-megapool-exit-requests.go 0.00% (ø) 5754 (+5754) 0 5754 (+5754)
github.com/rocket-pool/smartnode/rocketpool/node/check-minipool-exit-requests.go 0.00% (ø) 6214 (+6214) 0 6214 (+6214)
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-performance.go 0.10% (+0.10%) 6791 (+6791) 7 (+7) 6784 (+6784) 👍
github.com/rocket-pool/smartnode/rocketpool/node/node.go 0.00% (ø) 8997 (+1136) 0 8997 (+1136)
github.com/rocket-pool/smartnode/shared/services/bc-manager.go 0.53% (-0.06%) 6197 (+581) 33 6164 (+581) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client.go 6.87% (-0.57%) 262 (+20) 18 244 (+20) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client/std-http-client.go 0.01% (-0.00%) 16889 (+1665) 1 16888 (+1665) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client/types.go 2.44% (-0.19%) 492 (+36) 12 480 (+36) 👎
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.86% (+0.28%) 27134 (+5930) 234 (+110) 26900 (+5820) 👍
github.com/rocket-pool/smartnode/shared/services/performance/target-performance.go 0.75% (+0.75%) 8585 (+8585) 64 (+64) 8521 (+8521) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool/megapool.go 0.00% (ø) 2339 (+1271) 0 2339 (+1271)
github.com/rocket-pool/smartnode/shared/services/rocketpool/minipool.go 0.00% (ø) 1601 (+350) 0 1601 (+350)
github.com/rocket-pool/smartnode/shared/services/state/network-state.go 5.79% (-0.49%) 12602 (+1016) 730 (+2) 11872 (+1014) 👎
github.com/rocket-pool/smartnode/shared/services/state/static_bc.go 0.00% (ø) 1978 (+171) 0 1978 (+171)
github.com/rocket-pool/smartnode/shared/services/state/update-checks.go 0.00% (ø) 134 (+134) 0 134 (+134)
github.com/rocket-pool/smartnode/shared/types/api/minipool.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/api/node.go 4.76% (-0.36%) 735 (+52) 35 700 (+52) 👎
github.com/rocket-pool/smartnode/shared/types/api/pdao.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb/state_deneb.go 1.41% (-0.12%) 3823 (+294) 54 3769 (+294) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra/state_electra.go 0.00% (ø) 6255 (+1927) 0 6255 (+1927)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu/state_fulu.go 4.12% (+4.12%) 7082 (+2515) 292 (+292) 6790 (+2223) 👍
github.com/rocket-pool/smartnode/shared/types/eth2/fork/gloas/state_gloas.go 4.94% (-0.24%) 6699 (+1048) 331 (+38) 6368 (+1010) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/generic/state.go 11.11% (+11.11%) 27 (+27) 3 (+3) 24 (+24) 🎉
github.com/rocket-pool/smartnode/shared/types/eth2/types.go 0.80% (-0.13%) 1506 (+110) 12 (-1) 1494 (+111) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/rocketpool-cli/cli/verify-performance/verify-performance_test.go
  • github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-performance_test.go
  • github.com/rocket-pool/smartnode/rocketpool/watchtower/submit-network-balances_test.go
  • github.com/rocket-pool/smartnode/shared/services/megapools_test.go
  • github.com/rocket-pool/smartnode/shared/services/performance/target-performance_test.go
  • github.com/rocket-pool/smartnode/shared/types/eth2/fork/gloas/gloas_proofs_test.go
  • github.com/rocket-pool/smartnode/shared/types/eth2/participation_proof_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant