Skip to content

Remove ipv6-only bindings #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xfornax merged 2 commits into from
Oct 5, 2026
+6 −20
Merged

Remove ipv6-only bindings #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afb4a00
Remove ipv6-only bindings
0xfornax Oct 4, 2026
2bee4c6
ipv6 branch for Reth
0xfornax Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shared/services/rocketpool/assets/install/scripts/start-ec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,11 @@ if [ "$CLIENT" = "reth" ]; then
CMD="$CMD --max-inbound-peers=$RETH_MAX_INBOUND_PEERS"
fi

if [ ! -z "$EC_P2P_PORT" ]; then
CMD="$CMD --port $EC_P2P_PORT"
RETH_P2P_PORT=${EC_P2P_PORT:-30303}
CMD="$CMD --port $RETH_P2P_PORT --discovery.port $RETH_P2P_PORT --discovery.v5.port $RETH_P2P_PORT"

if [ "$ENABLE_IPV6" = "true" ]; then
CMD="$CMD --addr :: --discovery.v5.port.ipv6 $RETH_P2P_PORT"
fi

exec ${CMD}
Expand Down
2 changes: 1 addition & 1 deletion shared/services/rocketpool/assets/install/templates/eth1.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ services:
stop_grace_period: 15m
{{- $p2p := (or .ExecutionCommon.P2pPort.Value "30303")}}
{{- $torrent := (or .Erigon.TorrentPort.Value "42069")}}
ports: [ "{{if .IsIPv6Enabled}}[::]:{{end}}{{$p2p}}:{{$p2p}}/udp", "{{if .IsIPv6Enabled}}[::]:{{end}}{{$p2p}}:{{$p2p}}/tcp"{{if eq .ExecutionClient.String "erigon"}}, "{{$torrent}}:{{$torrent}}/udp", "{{$torrent}}:{{$torrent}}/tcp"{{end}}{{.GetECOpenAPIPorts}} ]
ports: [ "{{$p2p}}:{{$p2p}}/udp", "{{$p2p}}:{{$p2p}}/tcp"{{if eq .ExecutionClient.String "erigon"}}, "{{$torrent}}:{{$torrent}}/udp", "{{$torrent}}:{{$torrent}}/tcp"{{end}}{{.GetECOpenAPIPorts}} ]
volumes:
- eth1clientdata:/ethclient
- {{.RocketPoolDirectory}}/scripts:/setup:ro
Expand Down
17 changes: 0 additions & 17 deletions shared/services/rocketpool/assets/install/templates/eth2.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,34 +33,17 @@ services:
stop_grace_period: 3m
{{- $p2p := (or .ConsensusCommon.P2pPort.String "9001")}}
ports:
{{- if .IsIPv6Enabled}}
- "[::]:{{$p2p}}:{{$p2p}}/udp"
- "[::]:{{$p2p}}:{{$p2p}}/tcp"
{{- else}}
- "{{$p2p}}:{{$p2p}}/udp"
- "{{$p2p}}:{{$p2p}}/tcp"
{{- end}}
{{- if eq .ConsensusClient.String "lighthouse"}}
{{- if .IsIPv6Enabled}}
- "[::]:{{.Lighthouse.P2pQuicPort}}:{{.Lighthouse.P2pQuicPort}}/udp"
{{- else}}
- "{{.Lighthouse.P2pQuicPort}}:{{.Lighthouse.P2pQuicPort}}/udp"
{{- end}}
{{- else if eq .ConsensusClient.String "prysm"}}
- "{{.Prysm.P2pQuicPort}}:{{.Prysm.P2pQuicPort}}/udp"
{{- else if eq .ConsensusClient.String "lodestar"}}
{{- if .IsIPv6Enabled}}
- "[::]:{{.Lodestar.P2pQuicPort}}:{{.Lodestar.P2pQuicPort}}/udp"
{{- else}}
- "{{.Lodestar.P2pQuicPort}}:{{.Lodestar.P2pQuicPort}}/udp"
{{- end}}
{{- else if eq .ConsensusClient.String "nimbus"}}
{{- if .IsIPv6Enabled}}
- "[::]:{{.Nimbus.P2pQuicPort}}:{{.Nimbus.P2pQuicPort}}/udp"
{{- else}}
- "{{.Nimbus.P2pQuicPort}}:{{.Nimbus.P2pQuicPort}}/udp"
{{- end}}
{{- end}}
{{- if eq .ConsensusClient.String "teku"}}
- "{{.Teku.P2pQuicPort}}:{{.Teku.P2pQuicPort}}/udp"
{{- if .IsIPv6Enabled}}
Expand Down
Loading