Skip to content

Improved consistency of color variables - #1264

Merged
0xfornax merged 4 commits into
rocket-pool:masterfrom
freakynl:master
Oct 5, 2026
Merged

0xfornax merged 4 commits into
rocket-pool:masterfrom
freakynl:master

Conversation

@freakynl

@freakynl freakynl commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Improved consistency of color variables.

Might want to see if using fail() is preferred - the 'Unsupported OS' sections now error out themselves using multiple echo's for multiline output.

Variable consistency.

Might want to look into moving the output to fail() completely - but it's multi line.
Improved variable consistency
@freakynl

freakynl commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

For some reason I had issues upgrading.

Output was stuck after this:

$ r s install -d                                                                                                                                                                                                                                                                                        
The Rocket Pool 1.24.3 service will be installed.                                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                                                                           
If you're upgrading, your existing configuration will be backed up and preserved.                                                                                                                                                                                                                                          
All of your previous settings will be migrated automatically.                                                                                                                                                                                                                                                              
Are you sure you want to continue? [y/n]                                                                                                                                                                                                                                                                                   
y                                                                                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                                                                           
Skipping steps 1 - 2 (OS dependencies & docker)                                                                                                                                                                                                                                                                            
Step 3 of 9: Checking if docker-compose-plugin is installed...                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                                           
**ERROR**                                                                                                                                                                                                                                                                                                                  
The docker-compose-plugin package is not installed. Starting with v1.7.0, the Smart Node requires this package because the legacy docker-compose script is no longer supported.                                                                                                                                            
Since automatic dependency installation for the Linux operating system is not supported, you will need to install it manually. 

There's a line missing there as well. Not sure why it got stuck there - even if 'docker compose' failed (which it shouldn't):

$ docker compose; echo $?
Usage:  docker compose [OPTIONS] COMMAND
REMOVED MOST HELP OUTPUT
0

It should have output another line of text and ran exit. Maybe $RESET is set somewhere above the script? I don't see it in the script - nor in the users default variables - but it shouldn't even have hit the else clause.

Cloned git (main), made these modifications + removing output to /dev/null (as in line being 'if (docker compose version) ; then') and installed without issues then.

Nicely had version output below step 3 too.

$ r s install -d       
The Rocket Pool 1.24.3 service will be installed.    
                                                                              
If you're upgrading, your existing configuration will be backed up and preserved.
All of your previous settings will be migrated automatically.
Are you sure you want to continue? [y/n]                                                                                                                     
y                                                                             
                                                                              
Skipping steps 1 - 2 (OS dependencies & docker)                                                                                                                                                                                                                                                                            
Step 3 of 9: Checking if docker-compose-plugin is installed...                                                                                                                                                                                                                                                             
Docker Compose version 5.6.0                                                                                                                                                                                                                                                                                               
Already installed.                                                                                                                                                                                                                                                                                                         
Step 5 of 9: Checking for existing installation...                                                                                                                                                                                                                                                                         
Step 5 of 9: Backing up configuration settings to user-settings-backup.yml...                                                                                                                                                                                                                                              
Step 6 of 9: Creating Rocket Pool user data directory...                                                                                                                                                                                                                                                                   
Step 7 of 9: Copying package files to Rocket Pool user data directory...                                                                                                                                                                                                                                                   
Step 8 of 9: Cleaning up obsolete files from previous installs...                                                                                                                                                                                                                                                          
Step 9 of 9: Installing shell completion for rocketpool CLI...                                                                                                                                                                                                                                                             
Shell completion already configured in /home/rocket-user/.bashrc
Shell completion installed and configured. Restart your shell or run: source ~/.bash_completion.d/rocketpool

The Rocket Pool service was successfully installed!

@0xfornax

0xfornax commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Thanks for reporting it. Backticks around rocketpool service install -d make the shell execute that command instead of printing it. That's why it was hanging.

@0xfornax
0xfornax merged commit e522f8c into rocket-pool:master Oct 5, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants