Skip to content

STARSTEER-28862 [AI] Pin the host Python and fail the build when build.bat fails #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-rotanov-rogii merged 2 commits into from
Oct 12, 2026
Merged

STARSTEER-28862 [AI] Pin the host Python and fail the build when build.bat fails #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e14a8cb
STARSTEER-28862 [AI] Fail the Windows build when build.bat fails
d-rotanov-rogii Oct 12, 2026
1e34a6a
STARSTEER-28862 [AI] Build with a pinned host Python 3.14.7
d-rotanov-rogii Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 60 additions & 11 deletions rogii/build_common.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,25 +82,74 @@ set(
)

if(WIN32)
# PCbuild/find_python.bat takes externals/pythonx86 first and otherwise installs the latest
# pythonx86 from nuget; pythonx86 3.15 can no longer run the 3.12 regen scripts.
set(
HOST_PYTHON_VERSION
3.14.7
)
set(
HOST_PYTHON_DIR
"${CMAKE_CURRENT_LIST_DIR}/../externals/pythonx86"
)
set(
HOST_PYTHON_ARCHIVE
"${CMAKE_CURRENT_LIST_DIR}/../externals/pythonx86.${HOST_PYTHON_VERSION}.nupkg"
)
file(
DOWNLOAD
"https://api.nuget.org/v3-flatcontainer/pythonx86/${HOST_PYTHON_VERSION}/pythonx86.${HOST_PYTHON_VERSION}.nupkg"
"${HOST_PYTHON_ARCHIVE}"
EXPECTED_HASH
SHA512=d2bb139210513ab54821e82969131cadde68a86d8e2ed7d27cb747cf8aeb855e4e6d34261f5e86d1a7d7e68e773760e8a14970d6e426a67a3a4df27a89e341e5
TLS_VERIFY
ON
)
file(
REMOVE_RECURSE
"${HOST_PYTHON_DIR}"
)
file(
ARCHIVE_EXTRACT
INPUT
"${HOST_PYTHON_ARCHIVE}"
DESTINATION
"${HOST_PYTHON_DIR}"
)
if(NOT EXISTS "${HOST_PYTHON_DIR}/tools/python.exe")
message(
FATAL_ERROR
"pythonx86 ${HOST_PYTHON_VERSION} has no tools/python.exe"
)
endif()

set(
MSBUILD_PARAMS
"-v:n"
)
message (
"cmd /C ${BUILD_DIRECTORY}\\build.bat -c Release -p ${BUILD_ARCH}"
)
execute_process(
COMMAND
cmd /C "${BUILD_DIRECTORY}/build.bat -c Release -p ${BUILD_ARCH} ${MSBUILD_PARAMS}"
WORKING_DIRECTORY
"${BUILD_DIRECTORY}"
)
execute_process(
COMMAND
cmd /C "${BUILD_DIRECTORY}/build.bat -c Debug -p ${BUILD_ARCH} ${MSBUILD_PARAMS}"
WORKING_DIRECTORY
"${BUILD_DIRECTORY}"
foreach(
CONFIGURATION
Release
Debug
)
execute_process(
COMMAND
cmd /C "${BUILD_DIRECTORY}/build.bat -c ${CONFIGURATION} -p ${BUILD_ARCH} ${MSBUILD_PARAMS}"
WORKING_DIRECTORY
"${BUILD_DIRECTORY}"
RESULT_VARIABLE
BUILD_RESULT
)
if(NOT BUILD_RESULT EQUAL 0)
message(
FATAL_ERROR
"build.bat -c ${CONFIGURATION} -p ${BUILD_ARCH} failed: ${BUILD_RESULT}"
)
endif()
endforeach()

elseif(UNIX)
set(
Expand Down