Skip to content

fix(esm-shim): match typings to actual exports #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greymoth-jp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(esm-shim): match typings to actual exports #2013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/esm-shim/test/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import type { RollupOptions } from 'rollup';

import commonjsShim from '../types/index';
import esmShimDefault, { esmShim } from '../types/index';

const config: RollupOptions = {
input: 'main.js',
output: {
file: 'bundle.js',
format: 'iife'
},
plugins: [commonjsShim()]
plugins: [esmShimDefault(), esmShim()]
};

export default config;
5 changes: 3 additions & 2 deletions packages/esm-shim/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Plugin, SourceMapInput } from 'rollup';

interface Output {
export interface Output {
code: string;
map?: SourceMapInput;
}
Expand All @@ -10,5 +10,6 @@ interface Output {
*
* @returns Plugin instance.
*/
export default function commonjsShim(): Plugin;
export function esmShim(): Plugin;
export default esmShim;
export function provideCJSSyntax(code: string): Output | null;