Skip to content

[ntuple] Add option to preserve BigInt precision for Int64/UInt64 fields - #418

Merged
linev merged 1 commit into
root-project:devfrom
undefined-panda:rntuple-process-bigint
Aug 14, 2026
Merged

[ntuple] Add option to preserve BigInt precision for Int64/UInt64 fields#418
linev merged 1 commit into
root-project:devfrom
undefined-panda:rntuple-process-bigint

Conversation

@undefined-panda

@undefined-panda undefined-panda commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This Pull request:

Changes:

Add boolean variable for ReaderItem to process big integer values for Int64 and UInt64.

Fixes:

Process BigInt fields without losing precision due to Number() and without interferring with treeDraw.

@linev

linev commented Aug 14, 2026

Copy link
Copy Markdown
Member

Please check eslint warnings.

And one can use much simpler syntax when undefined value is fine.
There is no need for construct like:

const {preserveBigInt = false, ...restArgs} = args;

@linev linev self-assigned this Aug 14, 2026
@undefined-panda

Copy link
Copy Markdown
Contributor Author

Thanks for mentioning that! Javascript is a somewhat ... different language.
npm run check doesn't show any errors anymore. I removed the construct

@linev
linev self-requested a review August 14, 2026 13:28
@linev

linev commented Aug 14, 2026

Copy link
Copy Markdown
Member

All failures with node 20 are unrelated.

@linev
linev merged commit 84ead2c into root-project:dev Aug 14, 2026
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants