[ci] Try to fix retry logic - #18652
Merged
Merged
Conversation
When there is a problem during upload, the exception is correctly
caught but then during handling, another exception occurs:
File "/__w/root/root/.github/workflows/root-ci-config/build_utils.py", line 261, in upload_file
build_utils.print_warning(f"""Attempt {attempt} to upload {src_file} to {dest_object} failed. Retrying in {sleep_time} seconds...""")
NameError: name 'build_utils' is not defined
Test Results 19 files 19 suites 3d 21h 0m 34s ⏱️ For more details on these failures, see this check. Results for commit a4111cf. |
pcanal
approved these changes
May 8, 2025
Member
|
This change has been tested as part of #18469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a problem during upload, the exception is correctly caught but then during handling, another exception occurs:
Note: I didn't test if this fully fixes the try logic...