Repository navigation
[InterOp] Fix a build failure when configuring offline - #20011
Merged
Merged
Conversation
With llvm's include(Googletest), CppInterOp might download its own googletest, ignoring the system installation. This created several problems: - An existing system installation might be ignored. - When used in ROOT with builtin gtest, a conflicting gtest might be downloaded. - When ROOT is configured with fail-on-missing while offline, the configuration fails, because it is assumed that gtest needs to be downloaded. This is not the case, though, if gtest is present in the system. Therefore: - Test if the targets GTest::gtest or gtest exist. If found, no further actions are required. - New: If not found, run find_package(GTest). If found, continue as normal. - New: If not found, warn and disable the interop tests.
It was assumed that CppInterOp needs internet connection to download gtest. This should not be the case, any more, since it can use the system googletest or ROOT builtin targets. Therefore: - Remove the internet connnectivity check. It fails builds on Gentoo, because packages are always built without connection. - Change CPPINTEROP_ENABLE_TESTING from CACHE FORCE to CACHE. This enables users to override values when configuring. If they don't set any value, the value follows "testing=On/Off".
Test Results 22 files 22 suites 3d 21h 24m 40s ⏱️ Results for commit 72b979a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With llvm's include(Googletest), CppInterOp might download its own
googletest, ignoring the system installation. This created several
problems:
downloaded.
configuration fails, because it is assumed that gtest needs to be
downloaded. This is not the case, though, if gtest is present in the
system.
Therefore:
actions are required.
With the above, the logic in ROOT can be simplified:
CPPINTEROP_ENABLE_TESTINGbased on whethertestingis on or off.