Skip to content

[skip-ci] improve TPad::Divide help - #20260

Merged
couet merged 3 commits into
root-project:masterfrom
couet:pad_help
Nov 3, 2025
Merged

[skip-ci] improve TPad::Divide help#20260
couet merged 3 commits into
root-project:masterfrom
couet:pad_help

Conversation

@couet

@couet couet commented Oct 31, 2025

Copy link
Copy Markdown
Member

improve TPad::Divide help as requested here #20209

@couet couet self-assigned this Oct 31, 2025
@dpiparo
dpiparo requested a review from linev October 31, 2025 16:31
@rlalik

rlalik commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

This part of the documentation is also incorrect:

///  - xmargin is the space along x between pads in percent of canvas.
///  - ymargin is the space along y between pads in percent of canvas.

The more correct could look like:

///  - xmargin is the space around each pad along x, distance between pads along x is equal to 2*xmargin.
///  - ymargin is the space around each pad along y, distance between pads along y is equal to 2*ymargin.

@rlalik

rlalik commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

The new doc sounds really good. I was wondering only about perhaps replacing:

C->SetLeftMargin(0.3);
C->SetRightMargin(0.3);
C->SetTopMargin(0.3);
C->SetBottomMargin(0.3);

with

C->SetMargin(0.3, 0.3, 0.3, 0.3);

The former is very verbose, takes up vertical space. I like the way of setting all margins at once.

But beside that I think this can be merged. Unless you would like to wait for decision of my PR, because this will again change the definition (the old one will stay valid).

@couet

couet commented Nov 3, 2025

Copy link
Copy Markdown
Member Author

good I'll merge

@couet
couet merged commit 775ebc8 into root-project:master Nov 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants