[skip-ci] improve TPad::Divide help - #20260
Merged
Merged
Conversation
Contributor
|
This part of the documentation is also incorrect: /// - xmargin is the space along x between pads in percent of canvas.
/// - ymargin is the space along y between pads in percent of canvas.The more correct could look like: /// - xmargin is the space around each pad along x, distance between pads along x is equal to 2*xmargin.
/// - ymargin is the space around each pad along y, distance between pads along y is equal to 2*ymargin. |
2 tasks
linev
approved these changes
Nov 3, 2025
Contributor
|
The new doc sounds really good. I was wondering only about perhaps replacing: C->SetLeftMargin(0.3);
C->SetRightMargin(0.3);
C->SetTopMargin(0.3);
C->SetBottomMargin(0.3);with C->SetMargin(0.3, 0.3, 0.3, 0.3);The former is very verbose, takes up vertical space. I like the way of setting all margins at once. But beside that I think this can be merged. Unless you would like to wait for decision of my PR, because this will again change the definition (the old one will stay valid). |
Member
Author
|
good I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve TPad::Divide help as requested here #20209