[RF] Support FitGauss() also in RooMCStudy::plotParam() and friends - #23208
Merged
Conversation
So far, the FitGauss() command argument that overlays a Gaussian fit of the plotted distribution was only implemented for RooMCStudy::plotPull(). It is now also supported by plotParam(), and hence by plotError() and plotNLL(), which are implemented in terms of plotParam(). Fitting the distribution of the parameter itself with a Gaussian is what one needs for linearity studies, which is why it was requested in the issue. The code that fits the Gaussian, overlays it and adds the box with the fitted parameters is shared between the pull and the parameter case. The parameters of the Gaussian are seeded from the moments of the plotted distribution. Seeding them from the frame range instead would fail in two ways: the fitted width runs into the parameter limit if the distribution is much narrower than the frame, and the fitted mean is off if the frame range is not resolved by the precision of the RooWorkspace factory expression that builds the Gaussian. Closes root-project#12387. 🤖 Done with the help of AI
Test Results 22 files 22 suites 3d 10h 38m 37s ⏱️ Results for commit f4f24ad. |
dpiparo
approved these changes
Sep 1, 2026
dpiparo
left a comment
dpiparo
left a comment
Member
There was a problem hiding this comment.
Thanks. I know that may sound picky, but would it be useful to have a test for this new feature?
couet
removed their request for review
September 1, 2026 08:56
Contributor
Author
|
It is tested by the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the FitGauss() command argument that overlays a Gaussian fit of the plotted distribution was only implemented for RooMCStudy::plotPull(). It is now also supported by plotParam(), and hence by plotError() and plotNLL(), which are implemented in terms of plotParam(). Fitting the distribution of the parameter itself with a Gaussian is what one needs for linearity studies, which is why it was requested in the issue.
The code that fits the Gaussian, overlays it and adds the box with the fitted parameters is shared between the pull and the parameter case.
The parameters of the Gaussian are seeded from the moments of the plotted distribution. Seeding them from the frame range instead would fail in two ways: the fitted width runs into the parameter limit if the distribution is much narrower than the frame, and the fitted mean is off if the frame range is not resolved by the precision of the RooWorkspace factory expression that builds the Gaussian.
Closes #12387.
🤖 Done with the help of AI