[graf2d/graf] Eliminate gVirtualX usage from Graf classes - #23225
Merged
Conversation
Test Results 23 files 23 suites 3d 17h 35m 40s ⏱️ For more details on these failures, see this check. Results for commit 8376484. |
couet
approved these changes
Sep 2, 2026
in non-opaque moving line drawing is used. Replace gVirtualX by pad painter
As first step, combine 3d and normal loops over slices to draw contour lines. Take into account coordinate transformation
Make ExecuteEvent very simiar ro TBox
Both are very similar, therefore make similar changes. Do not store pad coordinates in the static variables, use in both firstPaint flaf
Via event argument provide flag when onlyX or onlyY can be changed. It can be used then in derived classes like TSliderBox
Use functionality of TBox::ExecuteEvent instead reimplementing it again. Depending on vertical or horizontal orientation of TSlider, either only X or only Y axis can be modified by the ExecuteEvent Also when setting min/max value back to TSlider, respect border values of TSlider itself.
linev
force-pushed
the
virtualx_graf2d
branch
from
September 2, 2026 08:38
8376484 to
bc50581
Compare
Now most of graphics classes do not use gVirtualX directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only change ExecuteEvent in the
TPie,TDiamond,TBoxandTSliderBoxclasses.These were last classes in
GrafandGpadlibrary.To be done: remove heavy use of static variables in
TPie.