Reapply "Store token literal data in PCH (ROOT-6794)." - #23235
Reapply "Store token literal data in PCH (ROOT-6794)."#23235siliataider wants to merge 2 commits into
Conversation
Test Results 19 files 19 suites 2d 14h 16m 14s ⏱️ Results for commit 99711aa. ♻️ This comment has been updated with latest results. |
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
As discussed offline, needed for the Python wheels.
I pushed a new tag to https://github.com/root-project/llvm-project/, please update interpreter/llvm-project/llvm-project.tag to the value ROOT-llvm22-20260902-01 (once CI has passed and all is confirmed working). Also, can you put the information from the PR summary into the commit message so it is preserved in the git history? The correct git hash of the merged commit should be aa5d17c (instead of 13b7480, which was the commit in the PR).
… expansion (ROOT-6794)." This reverts commit aa5d17c which breaks the Python wheels. The wheel's PCH is built on `manylinux_2_28` (glibc 2.28) and run on the `ubuntu-latest` runner (glibc 2.39). The system headers are present but different enough that cling reads the wrong bytes, and the lexer desyncs such that we get failures of the sort: ``` /usr/include/assert.h:37: error: failure when lexing a numeric literal ```
256a2ab to
99711aa
Compare
|
I believe somewhere on the llvm phabricator we had this opened as a change and was more or less fine but required a test. |
3 participants
Reapplies 9c8a650, reverted by #23165 in commit aa5d17c.
The revert breaks the Python wheels.
The wheel's PCH is built on
manylinux_2_28(glibc 2.28) and run on theubuntu-latestrunner (glibc 2.39). The system headers are present but different enough that cling reads the wrong bytes, and the lexer desyncs such that we get failures of the sort: