[core] rm C99 workaround for snprintf - #23240
Open
ferdymercury wants to merge 1 commit into
Open
Conversation
Test Results 4 files 4 suites 22h 18m 37s ⏱️ Results for commit e3e44fc. |
ferdymercury
commented
Sep 3, 2026
ferdymercury
marked this pull request as ready for review
September 3, 2026 06:47
ferdymercury
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
hageboeck,
jblomer,
linev,
pcanal and
vepadulano
as code owners
September 3, 2026 06:47
jblomer
reviewed
Sep 3, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! In principle looks good to me but the <cstdio> include should be in the include section of standard headers, below the ROOT includes.
ferdymercury
added
the
skip code analysis
ferdymercury
commented
Sep 3, 2026
ferdymercury
left a comment
ferdymercury
left a comment
Collaborator
Author
There was a problem hiding this comment.
mv to include section below or rm if duplicate
hageboeck
reviewed
Sep 3, 2026
ferdymercury
commented
Sep 3, 2026
ferdymercury
left a comment
ferdymercury
left a comment
Collaborator
Author
There was a problem hiding this comment.
mv to include section below or rm if duplicate
Collaborator
Author
oops sorry I missed that |
Member
No problem, let's just remove the include in the places where it's not needed. |
ferdymercury
force-pushed
the
rmsnprintf
branch
from
September 3, 2026 08:21
08467fa to
e7ff1fc
Compare
couet
removed their request for review
September 3, 2026 08:47
ferdymercury
force-pushed
the
rmsnprintf
branch
from
September 3, 2026 10:31
e7ff1fc to
6e350b2
Compare
it's part of the standard since C11, so no need for special wrapper use C++ header name mv C std headers to include section below or rm duplicate as suggested by jblomer
ferdymercury
force-pushed
the
rmsnprintf
branch
from
September 3, 2026 10:40
6e350b2 to
f855f3e
Compare
Collaborator
Author
I think I checked everywhere now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's part of the standard since C11, so no need for special wrapper