Skip to content

[tmva][sofie] explicit cast of senders and receivers to int64_t in GNN tutorial for safe run in mac - #23575

Merged
guitargeek merged 2 commits into
root-project:masterfrom
sanjibansg:fix/sofie/gnn/numpy
Oct 1, 2026
Merged

guitargeek merged 2 commits into
root-project:masterfrom
sanjibansg:fix/sofie/gnn/numpy

Conversation

@sanjibansg

Copy link
Copy Markdown
Collaborator

This PR adds explicit casts of senders and receivers values in TMVA SOFIE GNN Tutorial to int64_t for safe run in mac.

…VA_SOFIE_GNN tutorial through cppyy for safe run in mac

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for finding this solid workaround that makes the test green again.

Using import cppyy is a no-go, because it's a ROOT implementation detail. We have to find a different solution, which I'll try as soon as possible.

This PR though should be merged first to have passing tests, and then I can iterate on a real solution (possible in cppyy) with calm.

Can you maybe also try to fix tutorial-machine_learning-TMVA_SOFIE_RDataFrame-py? Thanks!

@guitargeek
guitargeek merged commit bb5fa27 into root-project:master Oct 1, 2026
35 of 37 checks passed
@guitargeek

Copy link
Copy Markdown
Contributor

Can you maybe also try to fix tutorial-machine_learning-TMVA_SOFIE_RDataFrame-py? Thanks!

Actually all good! Thanks to your initial work, I could understand the problem and open a PR that fixes the underlying problem in cppyy:

@sanjibansg
sanjibansg deleted the fix/sofie/gnn/numpy branch October 1, 2026 22:50
@sanjibansg

Copy link
Copy Markdown
Collaborator Author

Can you maybe also try to fix tutorial-machine_learning-TMVA_SOFIE_RDataFrame-py? Thanks!

Actually all good! Thanks to your initial work, I could understand the problem and open a PR that fixes the underlying problem in cppyy:

Thanks for the implementation. Apologies, I wasn't very clear on the cppyy thing, but glad it all works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants