Skip to content

[cmake] Only add the Core dependency to dictionaries when Core is a target #23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bellenot merged 3 commits into from
Oct 7, 2026
Merged

[cmake] Only add the Core dependency to dictionaries when Core is a target #23618

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29b8442
[cmake] Only add the Core dependency to dictionaries when Core is a t…
jmcarcell Oct 6, 2026
931d14d
Add always the Core or ROOT::Core dependency
jmcarcell Oct 6, 2026
449f28b
[cmake] Check ROOT::Core before Core
jmcarcell Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmake/modules/RootMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,8 +631,14 @@ function(ROOT_GENERATE_DICTIONARY dictionary)

#---Get the library and module dependencies-----------------
# Every dictionary implicitly depends on Core's pcm, except the one for Core itself.
# Only when building ROOT itself: downstream projects have no plain 'Core' target
# (only ROOT::Core), and a bare 'Core' in DEPENDS would be treated as a file.
if(ARG_MODULE AND NOT ARG_MODULE STREQUAL "Core")
list(INSERT ARG_DEPENDENCIES 0 Core)
if(TARGET ROOT::Core)
list(INSERT ARG_DEPENDENCIES 0 ROOT::Core)
elseif(TARGET Core)
list(INSERT ARG_DEPENDENCIES 0 Core)
endif()
list(REMOVE_DUPLICATES ARG_DEPENDENCIES)
endif()
foreach(dep ${ARG_DEPENDENCIES})
Expand Down
Loading