Repository navigation
Conversation
Use the same compression levels as the lz4 command line tool: level 1 is the fast compressor, level 2 is the medium compressor added in LZ4 1.10.0 (or the fast compressor with older versions), and higher levels use the high-compression (HC) compressor with the given level. With older LZ4 versions level 2 keeps using the fast compressor, as the lz4 tool does. The on-disk format does not change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Make the LZ4 compression levels follow those of the
lz4command line tool:lz4tool does; useLZ4_versionNumber()to check the LZ4 version at runtime;The on-disk format is unchanged, so files written with levels 2 and 3 remain readable by older ROOT versions. Users who explicitly write with LZ4 level 2 or 3 will get smaller files and slower compression.
Compressed size (in MiB and as a fraction of the input) and compression speed with
R__zipMultipleAlgorithm, on a sample of 10 CMS proton-proton raw data events (13.53 MiB, compressed as a single buffer):Without this PR the levels 2 and 3 are identical to level 1.
Checklist: